Forward ReportWorkloadState, and fix the build - #205
Merged
Conversation
The runner reaches the platform through this gateway, so without a forwarder here its reports answered Unimplemented and it fell back to letting reconciliation find the state -- correct, and silent.
The Gateway must implement every method of a service it registers, so these two missing forwarders failed the whole AgentsGateway handler and with it the build. Nothing showed it. The file watcher keeps serving the last binary that compiled, so the process stayed healthy while every route added since was quietly absent -- a new one answered 404 with no error anywhere to say the build had stopped succeeding.
The wait listed go.mod but not buf.gen.yaml, which the startup script generates from before it builds. A sync that dropped partway therefore let the container start on incomplete source, fail on the missing file, and crash-loop -- which then kept DevSpace from re-attaching to finish the very sync that would have repaired it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things.
ReportWorkloadStateforwarder so the runner's reports reach the runners service.The sandbox layout forwarders, which were missing. Go requires a handler to implement every method of the service it registers, so
GetSandboxLayout/SetSandboxLayoutbeing absent failed the wholeAgentsGatewayhandler and with it the build — this repo has not compiled against the published API since those RPCs were added.Nothing surfaced it: the dev file watcher keeps serving the last binary that compiled, so the process stayed healthy while every route added since was quietly absent. A new route answered 404 with no error anywhere saying the build had stopped succeeding.
Also fixes the devspace startup to wait for
buf.gen.yaml, so a partial sync no longer crash-loops in a way that blocks its own repair.