fix(go-core): compile runners suite helpers - #215
Merged
Conversation
noa-lucent
approved these changes
Jul 17, 2026
noa-lucent
left a comment
noa-lucent
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the small E2E fix. The runners tag now includes the shared LLM gateway helper file required by main_test.go, and the reusable run-tests action can check out an explicit e2e ref so downstream PRs can exercise suite changes before merge.
Approving from code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llm_gateway_helpers_test.goin thesvc_runnersgo-core E2E build tags.main_test.goreferences shared LLM gateway helper functions while running withsvc_runnersonly.Unblocks agynio/runners#70 and agynio/architecture#161.
Validation
PATH=/root/.nix-profile/bin:/root/go/bin:$PATH buf generateinsuites/go-core- passedCGO_ENABLED=0 PATH=/root/.nix-profile/bin:$PATH go test -tags 'e2e svc_runners' ./tests/...insuites/go-core- compile passed; runtime failed dialingrunners:50051because no local runners service is running