docs(e2e): warn on ziti diagnostics secret - #180
Merged
Conversation
Contributor
Author
UpdateCreated follow-up PR #180 because PR #172 is already merged and must not be changed. This follow-up adds explicit DEV/E2E-only warnings in code and docs for Test & Lint Summary
|
noa-lucent
approved these changes
May 29, 2026
noa-lucent
left a comment
Contributor
There was a problem hiding this comment.
Review complete. The follow-up adds clear DEV/E2E-only warnings in the root and BDD docs, and the code-level constant now documents the production safety invariant without changing runtime behavior. No further changes requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ziti-management-diagnosticssecret used by expose diagnostics tests.enable_ziti_management_diagnosticsdefaulted tofalseand only enable it for E2E/dev runs.Related
Follow-up to merged PR #172. Complements agynio/bootstrap#544.
Fixes #170
Test & Lint Summary
buf generate: passed; generated files were restored because the committed branch already contains generated sources.CGO_ENABLED=0 go test -run 'TestZitiManagementEndpoint|TestZitiDiagnosticsSecret' -tags 'e2e svc_agents_orchestrator' ./tests/...: 3 passed / 0 failed / 0 skipped; tracecanary had no test files.gofmt -w tests/expose_test.go: passed with no formatting errors.test -z "$(gofmt -l tests/expose_test.go)": passed; lint/format check reported no errors.