Skip to content

fix: list an app's groups as the app - #28

Merged
vitramir merged 1 commit into
mainfrom
fix/enroll-app-names-itself-to-groups
Aug 1, 2026
Merged

fix: list an app's groups as the app#28
vitramir merged 1 commit into
mainfrom
fix/enroll-app-names-itself-to-groups

Conversation

@vitramir

@vitramir vitramir commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

No first-party app can enroll — this is what the VM image build now dies on, for both reminders and telegram-connector:

enroll app: enroll app: internal: list app group memberships: list member groups:
rpc error: code = Unauthenticated desc = missing identity id

groups.ListMemberGroups allows a caller that is the member being listed, and otherwise requires organization membership. Neither caller of listAppGroups has a user identity to forward: EnrollApp authenticates with the app's service token, and HandleGroupMembershipEvent runs off NATS with no caller at all. The call went out bare and was refused.

The app is the member being listed, so it now names itself. That is the path groups already permits — no authorization rule changes.

A test pins it: it fails with got "" before the fix.

No app could enroll:

  enroll app: internal: list app group memberships: list member groups:
  rpc error: code = Unauthenticated desc = missing identity id

Groups lets a member list its own memberships and otherwise demands
organization membership. Both callers of listAppGroups have no user
identity to forward -- EnrollApp authenticates with the app's service
token, and the membership event handler runs off NATS with no caller at
all -- so the call arrived with nothing and was refused.

The app is the member being listed, so it names itself. That is the path
groups already allows; nothing in its rules changes.
@vitramir
vitramir merged commit eba9e85 into main Aug 1, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant