Repository navigation
fix(harness): use dynamic workspace root in middleware prompt #2194
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Copyright 2024-2026 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.agentscope.extensions.sandbox.agentrun; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| import io.agentscope.harness.agent.sandbox.WorkspaceSpec; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class AgentRunFilesystemSpecTest { | ||
|
|
||
| @Test | ||
| void defaultWorkspaceSpec_hasAgentRunRoot() { | ||
| AgentRunFilesystemSpec spec = new AgentRunFilesystemSpec(); | ||
| WorkspaceSpec ws = spec.workspaceSpec(); | ||
| assertEquals(AgentRunSandboxState.DEFAULT_WORKSPACE_ROOT, ws.getRoot()); | ||
| } | ||
|
|
||
| @Test | ||
| void workspaceSpec_doesNotMutateCallerObject() { | ||
| WorkspaceSpec caller = new WorkspaceSpec(); | ||
| caller.setRoot("/caller/root"); | ||
|
|
||
| new AgentRunFilesystemSpec().workspaceRoot("/explicit/root").workspaceSpec(caller); | ||
|
|
||
| assertEquals("/caller/root", caller.getRoot()); | ||
| } | ||
|
|
||
| @Test | ||
| void workspaceRootAndWorkspaceSpec_areOrderIndependent() { | ||
| WorkspaceSpec caller = new WorkspaceSpec(); | ||
| caller.setRoot("/caller/root"); | ||
|
|
||
| // workspaceRoot applied last wins | ||
| WorkspaceSpec specLast = | ||
| new AgentRunFilesystemSpec() | ||
| .workspaceSpec(caller) | ||
| .workspaceRoot("/last") | ||
| .workspaceSpec(); | ||
| // workspaceSpec applied last wins (its root) | ||
| WorkspaceSpec specFirst = | ||
| new AgentRunFilesystemSpec() | ||
| .workspaceRoot("/last") | ||
| .workspaceSpec(caller) | ||
| .workspaceSpec(); | ||
|
|
||
| assertEquals("/last", specLast.getRoot()); | ||
| assertEquals("/caller/root", specFirst.getRoot()); | ||
| } | ||
|
|
||
| /** | ||
| * The mount check inside {@code AgentRunSandboxClient.create()} must run against the | ||
| * backend-defaulted root, not the raw spec: a NAS mount at the default AgentRun root has to | ||
| * be recognised so {@code doDestroyWorkspace()} does not rm -rf persistent data. | ||
| */ | ||
| @Test | ||
| void defaultRoot_isUnderAgentRunNasMount() { | ||
| String nasMount = AgentRunSandboxState.DEFAULT_WORKSPACE_ROOT; | ||
| WorkspaceSpec defaulted = | ||
| WorkspaceSpec.withDefaultRoot(null, AgentRunSandboxState.DEFAULT_WORKSPACE_ROOT); | ||
|
|
||
| assertEquals(nasMount, defaulted.getRoot()); | ||
| assertTrue(defaulted.getRoot().startsWith(nasMount)); | ||
|
Collaborator
There was a problem hiding this comment. [Info] Minor nit: |
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workspaceRoot(String) mutates defaultWorkspaceSpec directly. If a caller first supplies a WorkspaceSpec via workspaceSpec(WorkspaceSpec) and then calls workspaceRoot(String), the caller's spec object is mutated. Conversely, if workspaceRoot(String) is called first and workspaceSpec(WorkspaceSpec) second, the root set by workspaceRoot is silently discarded. Preserve the configured root when replacing defaultWorkspaceSpec, or copy the spec before mutating it.