fix(install): skip empty CONTAINER_SOCK mount on Windows+WSL#930
Open
forcoder wants to merge 1 commit into
Open
fix(install): skip empty CONTAINER_SOCK mount on Windows+WSL#930forcoder wants to merge 1 commit into
forcoder wants to merge 1 commit into
Conversation
The embedded controller's podman run unconditionally mounted
-v "${CONTAINER_SOCK}:/var/run/docker.sock". On Windows + WSL
the installer cannot auto-detect a Unix socket path (no systemd,
no /run/podman/podman.sock), so CONTAINER_SOCK is empty and
podman fails with "host directory cannot be empty" — blocking every
install attempt.
Wrap the socket mount (and matching --security-opt) in a check for
non-empty CONTAINER_SOCK. Add an INFO log when running embedded and a
WARNING when the socket is missing, so users know Worker creation
won't work until a real Docker/Podman socket is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The embedded controller's
podman rununconditionally mounts-v "${CONTAINER_SOCK}:/var/run/docker.sock". On Windows + WSL the installer cannot auto-detect a Unix socket path (nosystemctl, no/run/podman/podman.sock), soCONTAINER_SOCKis empty and podman fails with "host directory cannot be empty" — blocking every install attempt on Windows.--security-opt label=disable) in a check for non-emptyCONTAINER_SOCKCONTAINER_SOCKis empty, telling users Worker creation won't work until a real Docker/Podman socket is availableTest plan
HICLAW_NON_INTERACTIVE=1 ./install/hiclaw-install.sh manager— should no longer fail with "host directory cannot be empty"HICLAW_MOUNT_SOCKET=0), verify the controller starts with a warning🤖 Generated with Claude Code