fix: require enforce as default, add normative silent-mode constraint - #28
Merged
Conversation
Add `"default": "enforce"` to enforcement_mode in both schema files. Update the description to accurately reflect that silent mode still records every would-have-denied decision in the audit chain; only operational logs are suppressed. Add normative MUST statements in spec/trace-v0.1.md: gateways MUST default to enforce, and a deployment MUST explicitly configure silent mode. Closes #19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"default": "enforce"toenforcement_modein bothschema/trace-claim.jsonandsrc/agentrust_trace/schema/trace-v0.1.json.enforcement_modedescription:silentmode still records every would-have-denied decision in the audit chain; only operational logs are suppressed (not "no logging").spec/trace-v0.1.md(section 3.1 field table and section 4.3 policy claim binding): gateways MUST default toenforce; a deployment MUST explicitly configuresilentmode.Closes #19.
Test plan
schema/trace-claim.jsonhas"default": "enforce"onenforcement_mode.src/agentrust_trace/schema/trace-v0.1.jsonhas the same.🤖 Generated with Claude Code