fix(epilabs-epi-recorder): drop the unschemad tested_against key blocking validate repo-wide - #158
Merged
Merged
Conversation
`tested_against` declares `additionalProperties: false` and permits five keys: cmcp-runtime, agentrust-trace, agentrust-trace-tests, agent-manifest, weight-custody-manifest. The manifest added a sixth, `epi-recorder`, pinning the integration's own version. This failed `validate` repo-wide, so every open PR in the repository was red on a manifest none of them touched. Local check after this change: 33 manifests, 0 failures. Removing the key rather than widening the schema keeps this to the minimum that unblocks the repository. Pinning an integration's own version in tested_against is a reasonable thing to want and is worth deciding on its own merits rather than under a repo-wide red. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012yyHFd4YA35oNUjhrztJSb
Second half of the same breakage. #148 added an integration without regenerating the index, so `validate` fails on "README integration index is stale" for every open PR in the repository, independently of the schema key fixed in the previous commit. Produced by running scripts/generate_integration_index.py, not by hand. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012yyHFd4YA35oNUjhrztJSb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateis failing on every open PR in this repository. The cause is one key in one manifest, and it is my fault for merging #148 while only its hold gate was reporting.tested_againstinschema/integration.schema.jsondeclaresadditionalProperties: falseand permits exactly five keys:cmcp-runtime,agentrust-trace,agentrust-trace-tests,agent-manifest,weight-custody-manifest. #148's manifest added a sixth,epi-recorder: "4.4.3", pinning the integration's own version.This removes that one line. The two valid pins stay.
Verified locally against
schema/integration.schema.jsonbefore pushing: 33 manifests, 0 failures.Why remove rather than widen the schema. @mohdibrahimaiml's intent is reasonable: an integration recording the version of itself that was tested is useful information, and
tested_againstis the natural home for it. But that is a schema decision worth making on its merits, not one to take while the repository is red. If we want it, addingepi-recorderalone would be wrong anyway; the right shape is a general way for an integration to pin its own version, and that deserves its own PR.What went wrong on my side, since it should not recur. #148 reported a single check when I merged it, its maintainer-hold gate, and
validatehad never run on the branch. I merged with--adminanyway. This repository'svalidatejob is a repo-wide gate: one bad manifest turns every open PR red, which is exactly what happened. A one-check rollup in this repository is a reason to release the held runs first, not a reason to reach for--admin.