Skip to content

docs: settle MAX_REQUEST_BYTES provenance (#573) - #585

Merged
imran-siddique merged 3 commits into
agentrust-io:mainfrom
Yatsuiii:docs/573-request-cap
Aug 27, 2026
Merged

docs: settle MAX_REQUEST_BYTES provenance (#573)#585
imran-siddique merged 3 commits into
agentrust-io:mainfrom
Yatsuiii:docs/573-request-cap

Conversation

@Yatsuiii

@Yatsuiii Yatsuiii commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Records the maintainer decision from #573 in docs/spec/proxy-security.md.

  1. Sets MAX_REQUEST_BYTES to 1_000_000 decimal.
  2. Records DOS-001 issue HIGH: No request body size limit before JSON parsing — pre-auth OOM via oversized payload (INJECT-001/DOS-001) #147 as the provenance.
  3. Documents the derived 500,000 byte string limit.
  4. States that MAX_JSON_NESTING_DEPTH and MAX_PARSE_TIME_MS must be evaluated against the 1MB cap.
  5. Keeps the 10MB value as a separate resource and denial of service design decision.

No runtime code changed.

Verification

The change is limited to docs/spec/proxy-security.md.

Closes #573.

Signed-off-by: Yatsuiii <battyrises@gmail.com>
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Yatsuiii
Yatsuiii marked this pull request as ready for review August 27, 2026 14:23
@Yatsuiii
Yatsuiii requested a review from a team as a code owner August 27, 2026 14:23

@imran-siddique imran-siddique left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against both implementations and the DOS-001 provenance in #147/#573. The patch correctly documents the enforced decimal 1,000,000-byte cap and derived 500,000-byte string limit.

@imran-siddique
imran-siddique merged commit 24b05ae into agentrust-io:main Aug 27, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MAX_REQUEST_BYTES: spec says 10MB, both implementations enforce 1MB

3 participants