components C3b: transcript polish + /thinking toggle - #295
Merged
Conversation
Transcript half of plan §3, completing C3: - compact boundary row: typed plumb (LocalCommandResult "compact" → CommandResult → dispatch compact flag → distinct boundary row); legacy REPL gained the compact elif so the executed command never falls through to re-handling - ctrl+o expand-last-truncated (legacy _expandable_blocks parity): tool results exceeding the panel limits stash full text under the ROW's authoritative name — production result events carry tool_name="" (review B1; all tests now use that shape) - read-group collapse: ≥3 consecutive completed Read/Grep/Glob rows fold into one summary row; breaks on user/assistant/thinking/ advisor/system rows, non-read tools, and errors; ONE ctrl+o stash entry per group tracked by identity (per-read content stashes interleave — the positional guard flooded the deque, review M2); boundary/group/expanded rows participate in the post-exit scrollback dump via _SnapshotStatic (review M3) - /thinking session toggle wired REAL: bridge → compat → QueryParams.extended_thinking; enable refuses honestly unless the provider+model actually support it (explicit True bypasses the query gate — review M4); first use disables (TS ThinkingToggle) 14 tests on production-shaped events; suite baseline-identical (the one transient delta re-verified as the documented prompt-assembly second-boundary flake, 3/3 isolated passes). Critic-approved after two rounds. Known cosmetic: after the first fold the group row stays pinned while later read rows flash below it briefly — closest achievable to TS static-region grouping. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
singlaamitesh
pushed a commit
to singlaamitesh/clawcodex
that referenced
this pull request
Jul 7, 2026
…b-transcript-polish components C3b: transcript polish + /thinking toggle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_expandable_blocksparity), read-group collapse (≥3 consecutive Read/Grep/Glob rows → one summary row, identity-tracked single ctrl+o stash entry), and a REAL/thinkingsession toggle (bridge → compat →QueryParams.extended_thinking, honest refusal on unsupported provider/model)tool_name=""in production — names now derive from the row (the tests use production shapes); boundary/group/expanded rows participate in the post-exit scrollback dump; break-set covers thinking/advisor/assistant/error pathsTest plan
_apply_command_resultthinking/compact branches, dispatch mapping🤖 Generated with Claude Code