feat(advisor): require explicit <provider>:<model> syntax (multi-provider rewrite)

[agentforce314]

Summary

Breaking change. The /advisor command no longer infers the provider from the model name. clawcodex is multi-provider — claude-opus-4-7 can live behind anthropic (direct), openai (litellm proxy), openrouter, bedrock, etc. Name-based inference silently routed to the wrong endpoint.

The user's test case surfaced this concretely: with claude-opus-4-7 configured in the openai provider entry (pointing at litellm.singula.ai) but the anthropic entry having no credits, /advisor claude-opus-4-7 would hit api.anthropic.com and 400 with credit balance too low.

New syntax

```
/advisor anthropic:claude-opus-4-7 # direct Anthropic
/advisor openai:claude-opus-4-7 # via litellm/proxy
/advisor openrouter:anthropic/claude-opus-4.1
/advisor gemini:gemini-2.5-pro
```

Splits on the first colon so model names with slashes/colons round-trip cleanly. Validates the provider key against ~/.clawcodex/config.json's providers map.

What changed

Layer	Change
src/settings/types.py	New advisor_provider: str = "" field.
src/state/app_state.py	New AppState.advisor_provider + _on_advisor_provider_change subscription.
src/command_system/builtins.py	/advisor requires <provider>:<model> syntax. New helpers _read_current_advisor_provider, _write_advisor_provider, _list_configured_providers.
src/utils/advisor.py	execute_client_advisor takes advisor_provider (no inference). decide_advisor_mode requires advisor_provider. format_advisor_status shows openai:opus-4-7 (colon, matches /advisor input).
src/query/query.py	Reads settings.advisor_provider and forwards to decide_advisor_mode.
src/tool_system/tools/advisor.py	Refuses if either advisor_model or advisor_provider is empty.
Tests	4 files updated: all /advisor invocations rewritten, fixtures set both fields, new tests for test_rejects_missing_colon and test_rejects_unknown_provider.

Dead code removed

• infer_provider_for_model (the model→provider prefix inference)
• _provider_is_using_custom_endpoint (the "reuse main provider if it has a custom endpoint" heuristic)
• TestInferProviderForModel test class
• Removed from __all__

These were the inference layer that the rewrite explicitly drops.

Critic-driven fixes (one round, all addressed)

• C1: partial-config status now surfaces advisor_client_mode when ON so users see stored state that would silently activate once both fields are filled.
• C2: --client alone checks BOTH current_advisor AND current_provider before enabling.
• C3: stale <model> syntax hint in an error message replaced with <provider>:<model>.
• S1: status bar uses colon (anthropic:opus-4-7) matching /advisor input syntax. User can copy from bar to command verbatim.
• S3: dropped fragile if configured guard — corrupt-config silent-skip turned into a loud error.

Breaking change migration

Existing users with settings.advisor_model = "claude-opus-4-7" (no advisor_provider set) will see:

• Status bar: advisor: ?/opus-4-7 (inactive)
• /advisor no-args: Advisor: not set\n(Found advisor_model='claude-opus-4-7' but no advisor_provider — clear with /advisor unset then re-run with the explicit syntax.)\nUse "/advisor <provider>:<model>" to enable, e.g.:\n /advisor anthropic:claude-opus-4-7 (direct Anthropic)\n /advisor openai:claude-opus-4-7 (via openai-compat, e.g. litellm)\n /advisor openrouter:anthropic/claude-opus-4.1

No silent failures; clear migration path.

Tests

• 677 passed across the full advisor + adapter + TUI + helpers + smoke + headless suites.

Live verified

The user's exact scenario:

```
~/.clawcodex/config.json:
settings:
advisor_model: claude-opus-4-7
advisor_provider: openai # was missing — now required
providers.openai.base_url: https://litellm.singula.ai

clawcodex --provider openrouter --model deepseek/deepseek-v4-pro -p "..."
```

Result: deepseek worker called advisor, the advisor request went via openai/litellm (NOT direct Anthropic), opus-4-7 returned real advice — "use heapq.nlargest(k, nums) for O(n log k) time. Handle edge cases: k <= 0 returns [], k >= len(nums) returns sorted...". The previous 400-credit-balance error is gone. Files created, exit 0, num_turns=6.

🤖 Generated with Claude Code