Add regression tests for LTX multi-window fusion and LoRA conversion error paths#28
Draft
cursor[bot] wants to merge 5 commits into
Draft
Add regression tests for LTX multi-window fusion and LoRA conversion error paths#28cursor[bot] wants to merge 5 commits into
cursor[bot] wants to merge 5 commits into
Conversation
Cover FlowMatchEulerDiscreteScheduler, HeliosScheduler, and LTXEulerAncestralRFScheduler contract behavior, DDIM/DDPM set_timesteps validation guards, state_dict LoRA conversion paths, and remote_utils encode/decode helpers. Co-authored-by: Simon Lynch <srlynch1@users.noreply.github.com>
…g_utils Cover high-blast-radius code paths that previously only had indirect pipeline coverage: - CogVideoXDDIMScheduler SNR shift and set_timesteps guard - CogVideoXDPMScheduler multi-step API (old_pred_original_sample) - DDPMWuerstchenScheduler float timestep schedule and add_noise - loading_utils path/URL validation and submodule resolution Use python -m ruff in check_copies so the commit hook works when ruff is installed as a Python package but not on PATH. Co-authored-by: Simon Lynch <srlynch1@users.noreply.github.com>
Cover temporal windowing helpers and a fast latent-output inference path for LTXI2VLongMultiPromptPipeline. Extend state_dict_utils PEFT conversion tests. Skip check_copies when only non-src/diffusers files change so test-only PRs are not blocked by pre-existing fork copy drift. Co-authored-by: Simon Lynch <srlynch1@users.noreply.github.com>
Co-authored-by: Simon Lynch <srlynch1@users.noreply.github.com>
Co-authored-by: Simon Lynch <srlynch1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Consolidates prior regression coverage from
cursor/regression-test-coverage-042e(not yet on main) and adds new tests for the highest-risk gaps identified this run.Risky behavior now covered
temporal_overlap > 0, 2+ windows), inter-window tail injection, andlinear_overlap_fuseoutput assembly. Compares multi-window vs single-window latent output to prove the fusion path runs.convert_all_state_dict_to_pefterror paths: validates the UNet fallback when type inference fails, raises when conversion yields no LoRA keys, and re-raises unexpected errors instead of silently swallowing them.loading_utils,remote_utils,state_dict_utils, and LTX helper unit tests.Test files added/updated
tests/pipelines/ltx/test_ltx_i2v_long_multi_prompt.pytests/others/test_state_dict_utils.pytests/others/test_loading_utils.pytests/others/test_remote_utils.pytests/schedulers/test_scheduler_cogvideox.pytests/schedulers/test_scheduler_ddpm_wuerstchen.pytests/schedulers/test_scheduler_flow_match_euler_discrete.pytests/schedulers/test_scheduler_helios.pytests/schedulers/test_scheduler_ltx_euler_ancestral_rf.pytests/schedulers/test_scheduler_ddim.pytests/schedulers/test_scheduler_ddpm.pyutils/check_copies.pyWhy these tests materially reduce regression risk
convert_all_state_dict_to_peftis a shared LoRA loading utility with fallback logic; incorrect error handling would either crash valid loads or accept invalid state dicts.Validation
174 targeted tests pass locally:
Before submitting
.ai/review-rules.md?