Add regression tests for schedulers, LoRA utils, and remote decode#16
Draft
cursor[bot] wants to merge 1 commit into
Draft
Add regression tests for schedulers, LoRA utils, and remote decode#16cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Cover high-blast-radius gaps: FlowMatchEuler, LTX RF ancestral, Helios multi-stage/UniPC corrector, DDIM/DDPM set_timesteps guards, LoRA Kohya conversion prefixes, and remote decode/encode validation. Co-authored-by: Simon Lynch <srlynch1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds fast unit tests covering high-blast-radius production paths that previously had no dedicated scheduler or utility coverage.
Risky behavior now covered
set_timesteps(stage_index=...), Euler step, UniPC corrector path on second stepset_timestepsguard whennum_inference_steps > num_train_timesteps(prevents inverted comparison regressions)Test files added/updated
tests/schedulers/test_scheduler_flow_match_euler_discrete.pytests/schedulers/test_scheduler_ltx_euler_ancestral_rf.pytests/schedulers/test_scheduler_helios.pytests/others/test_state_dict_utils.pytests/others/test_remote_utils.pytests/schedulers/test_scheduler_ddim.pytests/schedulers/test_scheduler_ddpm.pyWhy these tests materially reduce regression risk
SchedulerCommonTest; without dedicated contract tests, step-signature or timestep-schedule bugs slip through pipeline-only coverage.set_timestepsguard tests lock in correct comparison direction; an inverted check would reject all valid schedules.Validation
All 49 targeted tests pass locally:
Before submitting