feat(unstable): Add boolean config option capabilities#1490
Open
benbrandt wants to merge 1 commit into
Open
Conversation
Thinking about this more with a mind towards stabilizing, I am a bit worried about deserialization errors causing extreme breakage. If a client or SDK does not gracefully skip options it doesn't recognize, it may fail the whole response, which would break session/new, session/load, session/resume, etc. While no one would call set_config_option without understanding the option, the deserialization part, because it is on the main path and not a new notification that can be ignored, has me concerned. Given an agent can always fallback to providing a select with values "true" and "false" I think this should be a reasonable compromise.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking about this more with a mind towards stabilizing, I am a bit
worried about deserialization errors causing extreme breakage.
If a client or SDK does not gracefully skip options it doesn't
recognize, it may fail the whole response, which would break
session/new, session/load, session/resume, etc. While no one would call
set_config_option without understanding the option, the deserialization
part, because it is on the main path and not a new notification that can
be ignored, has me concerned.
Given an agent can always fallback to providing a select with values
"true" and "false" I think this should be a reasonable compromise.