chore: sync core lib and CLAUDE.md from agent-core#22
Merged
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of lib/ and CLAUDE.md from agent-core.
Note
Medium Risk
Changes file read/write behavior in
fixer.jsto reject symlink targets (including.backupfiles), which could alter or block existing workflows and affects filesystem-side effects.Overview
Hardens
lib/enhance/fixer.jsby introducingassertNotSymlink()and using it to refuse following symlinks for any file the fixer reads/writes, including.backupsiblings.applyFixes()now checks the target path before reading and again immediately before writing (narrowing TOCTOU), validates the backup path before creating backups, andrestoreFromBackup()similarly refuses symlinks for both backup and restore targets;assertNotSymlinkis exported.Reviewed by Cursor Bugbot for commit 76c2bb6. Configure here.