Repository navigation
Refactor streaming proxy room command - #505
Merged
Merged
Conversation
louis4li
marked this pull request as ready for review
April 29, 2026 03:31
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## dev #505 +/- ##
==========================================
- Coverage 71.62% 71.61% -0.01%
==========================================
Files 1236 1236
Lines 89573 89573
Branches 11713 11713
==========================================
- Hits 64156 64152 -4
- Misses 20819 20821 +2
- Partials 4598 4600 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #463 calls out that the streaming proxy room creation endpoint was carrying core lifecycle orchestration directly in the host/API surface. That made the endpoint responsible for actor creation, initialization, registry admission, and rollback.
Solution
StreamingProxyRoomCommandService.Impact
This keeps the host/API layer as composition and protocol mapping only, while the application layer owns the command lifecycle. Rollback now validates ownership first by unregistering registry ownership before destroying the actor.
Validation
dotnet test test/Aevatar.AI.Tests/Aevatar.AI.Tests.csproj --no-restore --filter "FullyQualifiedName~StreamingProxyRoomCommandServiceTests|FullyQualifiedName~StreamingProxyEndpointsCoverageTests|FullyQualifiedName~StreamingProxyCoverageTests" --nologopassed: 45/45.dotnet build agents/Aevatar.GAgents.StreamingProxy/Aevatar.GAgents.StreamingProxy.csproj --no-restore --nologopassed with NuGet warnings only.bash tools/ci/test_stability_guards.shpassed.git diff --checkpassed.src/Aevatar.Mainnet.Host.Apiin Development/InMemory/no-auth mode passed:POST /api/scopes/smoke-scope/streaming-proxy/roomsreturned200 OKwithroomId=streaming-proxy-8303b49646664caebadc98fe04c51238androomName=Review Smoke Room.GET /api/scopes/smoke-scope/streaming-proxy/roomsreturned200 OK,stateVersion=1, and the created room inrooms.bash tools/ci/architecture_guards.shpassed the C# architecture guards, then failed in the unrelated CLI playground asset build because@tanstack/react-virtualcould not be resolved fromtools/Aevatar.Tools.Cli/Frontend/src/runtime/ScopePage.tsx.Review
Ran the
superpowers:requesting-code-reviewflow. The reviewer found no critical issues and raised one P2 risk around blankScopeIdvalidation happening after actor creation. This PR includes the fix and a regression test that rejects blank scope before any actor side effect.