fix: [INFRA-673] Fix Jar properties extraction and Gradle support - #293
Merged
Conversation
alexs-aero
force-pushed
the
fix-673-fix-jar-meta-getter
branch
from
August 24, 2026 17:33
0e56878 to
cee1054
Compare
…th signatures and checksums Gradle consumers prefer .module over the Maven POM. deploy-artifacts only uploaded jar/pom (plus .asc and checksums), so published artifacts fell back to POM-only resolution. Structure and upload .module alongside jar/pom, including .module.asc in build-info and .module.md5/.sha1 without build-info. Keep signed checksums out of JFrog. Sign .module in sign-artifacts and cover the companions in deploy/sign tests.
alexs-aero
changed the title
mcbridem
reviewed
Aug 25, 2026
albertlagman
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief
Currently, if a specific JAR parent-child artifact would be posted with empty fields, it could result in empty properties and render workflow corrupted.
This PR extracts Jar property/coordinate handling into separate helper and updates all calls to use extracted properties
Summary
maven-helpersreads sibling POMs (including parent inheritance) so flat JARs and child modules resolvegroupId/artifactId/versioninstead of falling back to filename parsing. Document shaded-JARpom.propertiesbehavior..modulenext to jar/pom (nested GAV and POM-only BOMs), include.module.ascin build-info, upload.module.md5/.sha1without build-info, and keep signed checksums out of JFrog. Sign.modulein the GPG pass.my-app-1.0.0.module, standalone BOM +.module, and a registry guard soTYPE_COMPANIONS[jar]does not suffix-append.module.Changes
lib/maven-helpers.sh:_maven_read_pom_coordinates— full GAV + packaging/module count, with<parent>fallback_maven_read_pom_gav— GAV-only wrapper for callers that do not need packaging metadatareadget_jar_metadatasibling-POM path to merge only non-empty POM values (filename-derived fields preserved when POM leaves them blank)type_detection.shandentrypoint.shpom-only upload path (same parent-inheritance bug)type_detection.sh; simplify_pom_matches_flatten_resolved_heuristicto a single coordinate readmake_flat_jar_with_pomtest helper inmaven_fixtures.bashdocs/maven_lookup.md— resolution matrix, test coverage map, and known Stage 2 limitation for shaded uber JARs (firstpom.propertiesin zip order; not fixed here)Tests
Added to
test_metadata.bats:get_jar_metadata reads name, version and group from a sibling POM— direct GAV on<project>get_jar_metadata keeps filename pkgname when sibling POM inherits all GAV from parent— parent-only POM, no childartifactIdget_jar_metadata resolves child module GAV when sibling POM inherits groupId and version from parent— typical multi-module child shapeExisting maven structuring / bundle-metadata bats tests continue to pass.