Repository navigation
Read compiled template streams exactly - #157
Merged
adoconnection merged 1 commit intoOct 22, 2026
Merged
adoconnection merged 1 commit into
adoconnection merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream.ReadAsync may return fewer bytes than requested before reaching EOF. The compiled-template reader currently performs one read for each 8-byte length and payload, silently accepting incomplete data and corrupting the loaded template on valid short-read streams.
Read each requested buffer fully, and throw EndOfStreamException if the stream ends prematurely. The regression test round-trips a trusted synthetic Razor template through an in-memory stream that returns at most one byte per async read, then verifies the rendered output.
Validation:
dotnet test RazorEngineCore.Tests/RazorEngineCore.Tests.csproj --framework net10.0— 59 passed.dotnet build RazorEngineCore/RazorEngineCore.csproj --framework netstandard2.0— passed.git diff --check— passed.