Eslint: upgrade to version 8.0.0#3274
Merged
kodiakhq[bot] merged 1 commit intomasterfrom Dec 30, 2021
Merged
Conversation
tbergquist-godaddy
approved these changes
Dec 25, 2021
Member
Author
|
Hola @Brianzchen 👋 Would you happen to know why are the tests failing because of |
|
So I raised an issue about this here. I guess I understand what this dodgy code does now. My projects are on eslint v8 but I suppose it never impacted me because I never used this rules. This is an easy fix let me raise a PR for you shortly |
mrtnzlml
commented
Dec 29, 2021
mrtnzlml
commented
Dec 29, 2021
|
@mrtnzlml I think this can be merged now that all the plugins have been updated! |
See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known unresolved issues (with low impact )that we decided to accept: - mysticatea/eslint-plugin-node#301 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] ~wait for mysticatea/eslint-plugin-node#294 to be released and merged here~ replaced (probably temporarily) with `eslint-plugin-n` which supports Eslint 8 - [x] wait for facebook/react#22248 to be released and merged here - [x] release minor/patch version of Adeira Eslint Config before merging this breaking change - [x] switch `NEXT_VERSION_ERROR` to `ERROR` (#3625)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See:
Known unresolved issues (with low impact )that we decided to accept:
Known issues that need to be fixed first:
wait for Support ESLint 8.x mysticatea/eslint-plugin-node#294 to be released and merged herereplaced (probably temporarily) witheslint-plugin-nwhich supports Eslint 8NEXT_VERSION_ERRORtoERROR(Eslint config: convert allNEXT_VERSION_ERRORtoERROR#3625)