fix: fixes an mspack issue with a cab - #8
Open
activescott wants to merge 1 commit into
Open
Conversation
…si#193 also updates to make it compile and test with VS 2022; Remember to use the *x86* Native Tools Command Prompt for VS 2022
activescott
commented
Jul 12, 2024
| cab->base.prevname = cabd_read_string(sys, fh, &err); | ||
| if (err) return err; | ||
| cab->base.previnfo = cabd_read_string(sys, fh, &err); | ||
| // in at least one CAB the nextname was set but nextinfo was empty; so we allow an empty nextinfo here |
Owner
Author
There was a problem hiding this comment.
NOTE: This is the core fix here on the mspack side. Some of these multipart cabs seem to have empty nextinfo's and we need to safely ignore that
activescott
commented
Jul 12, 2024
| foreach (var f in files) | ||
| ExplodeCab(f); | ||
| var root = TestFilesPath; | ||
| string[] files = Directory.GetFiles(root, "*.cab"); |
Owner
Author
There was a problem hiding this comment.
todo: fix formatting. Why does vs allow this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I expect this to fix or at least partially fix activescott/lessmsi#194 . Doing some more testing locally before merging
Also updates to make it compile and test with VS 2022; Remember to use the x86 Native Tools Command Prompt for VS 2022.
Tasks: