Skip to content

Test against Rails 7.2#599

Merged
tagliala merged 1 commit intoactiveadmin:masterfrom
tagliala:feature/rails_72
Aug 10, 2024
Merged

Test against Rails 7.2#599
tagliala merged 1 commit intoactiveadmin:masterfrom
tagliala:feature/rails_72

Conversation

@tagliala
Copy link
Copy Markdown
Contributor

@tagliala tagliala commented Jun 10, 2024

@tagliala tagliala force-pushed the feature/rails_72 branch 3 times, most recently from 8f39de6 to 5dd5681 Compare June 10, 2024 18:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (22ea773) to head (5045c95).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #599   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files          17       17           
  Lines         458      458           
=======================================
  Hits          432      432           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread .github/workflows/ci.yml Outdated
Comment on lines +18 to +25
- 3.1
- 3.2
- 3.3
deps:
- "3.1"
- "3.2"
- "3.3"
rails:
- rails_61
- rails_70
- rails_71
- rails_72
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parity with inherited_resources

@tagliala tagliala marked this pull request as ready for review August 10, 2024 08:05
@tagliala tagliala requested a review from javierjulio August 10, 2024 08:25
Copy link
Copy Markdown
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit ce67f00 into activeadmin:master Aug 10, 2024
@tagliala tagliala deleted the feature/rails_72 branch August 10, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants