Add RuboCop performance#544
Merged
tagliala merged 2 commits intoactiveadmin:masterfrom Oct 25, 2023
Merged
Conversation
tagliala
force-pushed
the
chore/add-rubocop-performance
branch
2 times, most recently
from
d55a7f7 to
3bb9020
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #544 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 17 17
Lines 460 460
=======================================
Hits 425 425
Misses 35 35
☔ View full report in Codecov by Sentry. |
javierjulio
reviewed
Oct 24, 2023
tagliala
force-pushed
the
chore/add-rubocop-performance
branch
2 times, most recently
from
e1b460f to
5ddfaa8
Compare
Also removes RuboCop from `/gemfiles`
- Performance/BlockGivenWithExplicitBlock - Performance/StringReplacement
tagliala
force-pushed
the
chore/add-rubocop-performance
branch
from
5ddfaa8 to
dc30d9c
Compare
javierjulio
approved these changes
Oct 25, 2023
Member
javierjulio
left a comment
javierjulio
left a comment
There was a problem hiding this comment.
@tagliala thanks! You are all set to merge here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autofix save RuboCop performance offenses