Skip to content

Compability with Rails's main branch (7.0.0.alpha)#281

Closed
dorianmariecom wants to merge 1 commit intoactiveadmin:masterfrom
dorianmariecom:master
Closed

Compability with Rails's main branch (7.0.0.alpha)#281
dorianmariecom wants to merge 1 commit intoactiveadmin:masterfrom
dorianmariecom:master

Conversation

@dorianmariecom
Copy link
Copy Markdown

I ran the tests and everything is green.

I updated the rails version used in the local Gemfile to the latest commit on rails/rails main branch.

I figured if you want to test against different versions of rails you could use appraisal https://github.com/thoughtbot/appraisal

Really not sure about my approach, let me know what you think ❤️

@dorianmariecom
Copy link
Copy Markdown
Author

the tests are failing because:

activesupport-7.0.0.alpha requires ruby version >= 2.7.0, which is incompatible

so I "downgraded" rails locally to 6.1.3

@dorianmariecom
Copy link
Copy Markdown
Author

ok, removed the upgrades because it's failing on jruby, will do a separate PR

Comment thread arbre.gemspec
s.required_ruby_version = '>= 2.5'

s.add_dependency("activesupport", ">= 3.0.0", "< 6.2")
s.add_dependency("activesupport", ">= 3.0.0", "< 7.0")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that Rails 7 is released, this should probably be changed to:

Suggested change
s.add_dependency("activesupport", ">= 3.0.0", "< 7.0")
s.add_dependency("activesupport", ">= 3.0.0", "< 8.0")

@sunny
Copy link
Copy Markdown

sunny commented Dec 16, 2021

The Gemfile.lock seems to be tracked here, so the PR should probably reflect changes in the Gemfile.lock as well.

@sunny sunny mentioned this pull request Dec 16, 2021
@javierjulio
Copy link
Copy Markdown
Member

We'll tackle this in #314 thanks!

@dorianmariecom dorianmariecom deleted the master branch January 22, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants