Add 'main' to HTML5 elements#270
Merged
Merged
Conversation
Contributor
Author
|
Can any maintainer please take a look at this change? |
Contributor
Author
|
Is this project still maintained? @deivid-rodriguez @javierjulio |
|
@mynnx I don't think this project is still actively maintained but it's pretty darn close to being maintained. Try pinging the maintainers again. |
Contributor
Author
|
At @karloscarweber 's suggestion,
|
deivid-rodriguez
force-pushed
the
add-main-element
branch
from
d4c481b to
af96270
Compare
deivid-rodriguez
approved these changes
Jun 16, 2022
Member
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Sorry for not getting to this earlier, it looks good to me! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From MDN:
It's been in the spec since 2012 and I'd love to improve the accessibility of ActiveAdmin by including it!