Fix ruby 2.7 warnings#202
Merged
javierjulio merged 1 commit intomasterfrom May 18, 2020
Merged
Conversation
Member
Author
|
@javierjulio This is ready if you're ok with it. |
javierjulio
approved these changes
May 18, 2020
Member
javierjulio
left a comment
javierjulio
left a comment
There was a problem hiding this comment.
Yes, I think its great, thanks! My preference too would be to avoid the dependency here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a gem to get "compatible delegation" working, but it seems overkill to me to introduce a dependency just for this, and we're going to need to update the code anyways once we drop support for ruby 2.6, so I think this is fine.
Closes #167.