Skip to content

Make both upload concurrency and timeout settings configurable with env variables. - #1928

Merged
yacaovsnc merged 4 commits into
mainfrom
yacaovsnc/artifact_upload_concurrency_and_timeout
Jan 8, 2025
Merged

Make both upload concurrency and timeout settings configurable with env variables.#1928
yacaovsnc merged 4 commits into
mainfrom
yacaovsnc/artifact_upload_concurrency_and_timeout

Conversation

@yacaovsnc

@yacaovsnc yacaovsnc commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

Make both upload concurrency and timeout settings configurable with env variables.

Concurrency setting can only be lowered with the env variable, the goal is not to increase performance, but to stabilize the upload process.

@yacaovsnc
yacaovsnc requested a review from a team as a code owner January 8, 2025 16:21
@yacaovsnc
yacaovsnc force-pushed the yacaovsnc/artifact_upload_concurrency_and_timeout branch from 5119304 to 7e3aa62 Compare January 8, 2025 18:00
@yacaovsnc yacaovsnc changed the title Set default concurrency to 10 and make timeout configurable Make both upload concurrency and timeout settings configurable with env variables. Jan 8, 2025
Comment thread packages/artifact/src/internal/shared/config.ts Outdated
@yacaovsnc
yacaovsnc force-pushed the yacaovsnc/artifact_upload_concurrency_and_timeout branch from 7e3aa62 to ede05b9 Compare January 8, 2025 18:11
@yacaovsnc
yacaovsnc merged commit 16ef144 into main Jan 8, 2025
@jww3
jww3 deleted the yacaovsnc/artifact_upload_concurrency_and_timeout branch January 9, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants