Skip to content

Add msbuild.json as problem matcher (#603) - #605

Closed
Falco20019 wants to merge 1 commit into
actions:mainfrom
Falco20019:feature/msbuild-matcher
Closed

Add msbuild.json as problem matcher (#603)#605
Falco20019 wants to merge 1 commit into
actions:mainfrom
Falco20019:feature/msbuild-matcher

Conversation

@Falco20019

Copy link
Copy Markdown
Contributor

Description:
Added msbuild.json as seperately owned matched. This makes it possible to disable it seperately. Tests are added and I used it in our CI pipeline already.

Related issue:
#603

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@Falco20019
Falco20019 requested a review from a team as a code owner February 26, 2025 11:05
@Falco20019

Copy link
Copy Markdown
Contributor Author

Anything I could do to help you on gettings this reviewed?

@Falco20019

Copy link
Copy Markdown
Contributor Author

Any chance to get this fixed?

@Falco20019

Copy link
Copy Markdown
Contributor Author

Ping @aparnajyothi-y @lmvysakh @HarithaVattikuti

@Falco20019

Falco20019 commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Another ping as it's 6 months. Just let me know if it's even wanted. If yes, I can rebase and fix conflicts. If no, I can close it.

/CC @priya-kinthali @HarithaVattikuti

@priya-kinthali

Copy link
Copy Markdown
Contributor

Hello @Falco20019👋,
Thank you for this PR! As mentioned in #603, at this point, we haven't seen enough community demand to prioritise this, but we'll consider exploring the possibility of incorporating these changes in a future update as we gather more community engagement and interest. Thanks again for your contribution!

@lmvysakh

Copy link
Copy Markdown

Hello @Falco20019,

Thank you for your contribution. We have reviewed the PR and wanted to let you know that, the regex currently requires the [project] suffix to be present for a match. However, not all MSBuild error/warning messages may include the project path in brackets. Since audit output legitimately appears in both forms( with and without [project] suffix ), the matcher could be updated to treat the trailing \[...\] group as optional to reliably annotate NuGet audit warnings.

Also could you please take the latest changes from the main branch and resolve the merge conflicts ?

@Falco20019

Copy link
Copy Markdown
Contributor Author

I am not using GitHub Actions anymore, so I will drop this. Totally forgot about it after that long time. Might also be covered by #717 that recently got merged.

@Falco20019 Falco20019 closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants