Skip to content

[FIX] Add explicit include to coveragerc - #9

Closed
lasley wants to merge 1 commit into
acsone:masterfrom
LasLabs:hotfix/coverage-ignore
Closed

lasley wants to merge 1 commit into
acsone:masterfrom
LasLabs:hotfix/coverage-ignore

Conversation

@lasley

@lasley lasley commented Jan 23, 2017

Copy link
Copy Markdown
Contributor

I noticed a coverage drop when I edited the ReadMe in #8. This PR should fix that by providing an explicit includes for only python files in the package directory.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.007% when pulling 03c3229 on LasLabs:hotfix/coverage-ignore into 115f7e9 on acsone:master.

3 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.007% when pulling 03c3229 on LasLabs:hotfix/coverage-ignore into 115f7e9 on acsone:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.007% when pulling 03c3229 on LasLabs:hotfix/coverage-ignore into 115f7e9 on acsone:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.007% when pulling 03c3229 on LasLabs:hotfix/coverage-ignore into 115f7e9 on acsone:master.

@lasley
lasley force-pushed the hotfix/coverage-ignore branch from 03c3229 to 6717936 Compare January 23, 2017 18:25
@coveralls

coveralls commented Jan 23, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 89.007% when pulling 6717936 on LasLabs:hotfix/coverage-ignore into 115f7e9 on acsone:master.

@lasley

lasley commented Jan 23, 2017

Copy link
Copy Markdown
Contributor Author

I feel like maybe I did something wrong though, because there should have been a coverage raise here 😕

@lasley

lasley commented Jan 31, 2017

Copy link
Copy Markdown
Contributor Author

Hrm so whatever was dropping the coverage is fixed, because my PR now raised coverage. This is definitely not right & I don't know enough about coveragerc to make it right. All that in mind, closing.

@lasley lasley closed this Jan 31, 2017
@lasley
lasley deleted the hotfix/coverage-ignore branch January 31, 2017 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants