Replace kaptan with direct PyYAML SafeLoader usage - #71
Closed
rjocoleman wants to merge 1 commit into
Closed
rjocoleman wants to merge 1 commit into
rjocoleman wants to merge 1 commit into
Conversation
legalsylvain
approved these changes
Apr 3, 2023
legalsylvain
left a comment
There was a problem hiding this comment.
@sbidoul could you run test ? (As it is a first contribution)
thomaspaulb
approved these changes
Jul 18, 2023
This was referenced Jul 18, 2023
Member
|
Thanks for this contrib. Since there was a merge conflict I finished it in #76. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the kaptan configuration parser with direct usage of PyYAML's SafeLoader class.
Why:
PyYAML>=3.13,<6, which is lower than the currently released 6.0. This can lead to dependency resolution issues.How:
Caveats:
.yamlandymlfile extensions are supported. This check can be easily removed to revert to previous filename behaviour.