fix: stackline appears behind floating window (#279)#325
fix: stackline appears behind floating window (#279)#325Swoorup wants to merge 3 commits intoacsandmann:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d80df614e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
acsandmann
changed the title
sytherax
force-pushed
the
sjoshi/fix-stackline-ui-window-level
branch
from
d80df61 to
5e919e4
Compare
|
Swoorup
force-pushed
the
sjoshi/fix-stackline-ui-window-level
branch
from
5e919e4 to
0435b9b
Compare
|
looks good i just need to test and ill merge. thanks for the pr |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0435b9b0c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Swoorup
force-pushed
the
sjoshi/fix-stackline-ui-window-level
branch
from
0435b9b to
0335dbe
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0335dbefa3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if self.point_hits_stack_line(loc) { | ||
| return false; |
There was a problem hiding this comment.
on_event now drops mouse-down events whenever point_hits_stack_line is true, but that predicate uses the expanded hit margins while GroupIndicatorWindow::segment_at_point_static only accepts points inside the indicator frame. In the margin ring (outside frame but inside margin), the event is suppressed here and stack_line::handle_mouse_down performs no action, so the click is lost instead of reaching the underlying window. This introduces dead zones around every indicator (up to the configured hit margins).
Useful? React with 👍 / 👎.
|
@Swoorup could we only use one method of hit testing? im fine with the implementation in event_tap but make that be the only hit testing implementation we have. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f5a030d6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if self.point_hits_stack_line(loc) { | ||
| let _ = tx.try_send(stack_line::Event::MouseDown(loc)); | ||
| return false; |
There was a problem hiding this comment.
point_hits_stack_line uses expanded hit margins, but stack_line::handle_mouse_down only activates when check_click lands inside the indicator frame; as a result this early return false can consume clicks in the margin area (e.g., several pixels around the bar) without focusing any segment and without passing the click to the underlying app window. This creates user-visible lost clicks whenever the pointer is close to the indicator edge.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
To use Codex here, create an environment for this repo.
|
Anything remaining here @acsandmann ? |
2 participants
I got too annoyed by this issue #279 . Fixes both stackline appearing at incorrect levels when spotlight ui and floating window are present.
Only caveat is that for some reason, macos applies shadow effect when in-between windows (looks rather cool though and natural)