chore: migrate to cctp v2 - #1535
Conversation
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea27086571
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Math.min(10_000, Math.max(1, deadline - Date.now())) | ||
| ); | ||
| } catch (error) { | ||
| if (!isHttpError(error) || (error.status !== 404 && error.status !== 429 && error.status < 500)) throw error; |
There was a problem hiding this comment.
When an Iris request is aborted by the per-request timeout at line 347 or rejects because of a transient network error, fetchWithTimeout throws a non-HttpError, so this condition immediately exits instead of continuing until timeoutMs. This makes the polling helper fail after the first slow or interrupted request—even though the overall deadline may have substantial time remaining—while only HTTP 404/429/5xx responses receive the intended retry behavior.
Useful? React with 👍 / 👎.
Signed-off-by: Ihor Farion <ihor@umaproject.org>
1 participant
No description provided.