Factor out posix_spawnp(3)/waitpid(2) calls to a new function#57
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR refactors repeated posix_spawnp(3) + waitpid(2) sequences used to open a text editor for JSON edits into a shared open_editor() helper, reducing duplication across multiple interactive flows in itsa.
Changes:
- Introduces
get_editor()/open_editor()helpers and reuses them across editor-invoking sites. - Removes duplicated inline spawn/wait logic from
annual_summary,trigger_bsas, andamend_savings_account.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There are several places where we do a posix_spawnp(3) followed by a waitpid(2) to open a text editor to edit some JSON. Factor these sites out into their own function, open_editor(). Assisted-by: GitHub Copilot:claude-opus-4.5 Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several places where we do a posix_spawnp(3) followed by a waitpid(2) to open a text editor to edit some JSON.
Factor these sites out into their own function, open_editor().
Assisted-by: GitHub Copilot:claude-opus-4.5