Walrus operator marked as syntax error #94

Activity

1. abulka commented on Jun 29, 2021

   

   abulka

   on Jun 29, 2021

   Owner

   More actions

   This seems to pass OK under Python 3.9

   def test_issue_walrus_issue_94(self):
       source_code = dedent("""
           if (pair := chairs.get(number, None)) is None:
               pass
       """
       )
       pmodel, debuginfo = parse_source(source_code, 
                                           options={"mode": 3}, 
                                           html_debug_root_name="test_issue_walrus_issue_94")
       self.assertNotIn("error", pmodel.errors)

   Perhaps this error only happens with a lower version of Python - will need to check. As it stands, it looks promising that no changes to the Pynsource parser are needed, only a Python version bump. That is, assuming the source code fragment above reproduces the problem.
2. abulka

   added a commit that references this issue on Jun 29, 2021

   test for issue #94

   0e73a0b
3. abulka

   added

   Needs new binary releaseNeeds to build binaries/executables and make a formal new releaseNeeds to build binaries/executables and make a formal new release

   Component-Parsing

   on Jul 1, 2021
4. abulka

   added a commit that references this issue on Jul 1, 2021

   better tests and parsing for issue #85, #93, #94 - tests pass under p…

   ...

   ff83263
5. alexchandel commented on Jul 2, 2021

   

   alexchandel

   on Jul 2, 2021

   Author

   More actions

   I think walrus entered in 3.8. I have 3.9 installed in /usr/local (macOS) but I assume you don't use that. Source fragment was something like:

   chairs: dict[int, str]
   number: int
   ...
   if (pair := chairs.get(number, None)) is None:
       ...
6. abulka

   added a commit that references this issue on Jul 3, 2021

   test_issue_walrus_issue_94() now tested for in python 3.8, see #94

   74b14ea
7. abulka commented on Jul 8, 2021

   

   abulka

   on Jul 8, 2021

   Owner

   More actions

   Latest master branch and 1.78 beta binary release should have fixed this.
   Official 1.78 release only a few days away.

   Note: Ubuntu Snap is stuck at Python 3.6 till Canonical fix their Snapcraft core20 stuff.
8. abulka

   closed this as completedon Jul 8, 2021