Repository navigation
fix(mcp): raise SDK floor and audit minimum-compatible profiles - #347
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Exact-head verificationReviewed head: All 32 checks succeeded, including release gate and the eight MCP cells, in CI run 40615540692. Automatic Codex code and security reviews completed at the exact head with no findings and no review threads. No admin/protection bypass was used. Downloaded all eight This validates the SDK lower bound and latest-compatible resolution, not every transitive dependency's minimum. It does not prove a remotely exploitable issue in the stdio-only application, native-agent delivery, live OAuth or Windows process-tree acceptance. Final integrated release/main checks and publication verification remain separate gates. |
Summary
Raise the optional MCP extra from
mcp>=1.12,<2tomcp>=1.30,<2, preserving the Python 3.10 marker and dependency-free Python 3.9 core. The reviewed application explicitly uses stdio; this is dependency-policy hardening, not remediation of a demonstrated exploitable HTTP/OAuth/client issue in session-peer.Expand the existing release-gated MCP job to macOS/Linux × Python 3.10/3.13 × minimum/latest:
Update the MCP guide in four languages and add executable workflow regressions for exact installation branches, failure propagation, installed-SDK-independent metadata checks, wrong/missing versions and audit exit/report retention. No product transport, policy, timeout or retry behavior changes.
Closes #346.
Local validation
Independent review
Before PR creation, Claude Code 2.1.310 (requested and response-confirmed
claude-opus-5-5) and Codex CLI 0.164.0 (isolated default model; actual model ID not exposed) ran non-interactively in parallel on the same immutable input SHA-2560d8f9ef478f399cd2d2add9745c9869e1bd5209b3d37e0f9aa478f599ec7f39d. Both completed successfully, without tools, writes, tests or network. Claude required correction of the tooling/environment claim; Codex recommended that clarification. Codex checked source facts and clarified the included bootstrap packages, then addressed report-after-test-failure, host-SDK contamination, optimization-sensitive assertions and installation-branch coverage. These follow-up changes were validated by Codex's executable regressions; the initial frozen reviews are not claimed to cover unchanged final bytes.Antigravity CLI 1.4.8, explicit
gemini-3.8-flash-medium, read-only translation QA (structured success, 100.272 seconds) compared all four MCP guides. Codex verified and applied narrow terminology, bounded-cleanup and framing corrections; no new runtime or platform claim was introduced. The final small bootstrap clarification was checked by Codex, not a claimed second Gemini review.No native model calls, credentials, service deployment, global installation or permission/settings changes. v1.3.2 publication remains subject to final source/CI/artifact verification and the required human PyPI environment approval.