Repository navigation
fix(ssh): preserve listing when version probes fail - #271
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The candidate branch now includes the source-map-js lockfile-only repair from PR #269 to unblock the existing Control audit gate. This does not merge anything into main or alter service deployment. Rechecking CI and code/security reviews against the updated head. |
|
@codex review |
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…65-20261007 # Conflicts: # docs/i18n-manifest.json
|
Integrated current main through #273 in b0ff418. Both CLI documentation changes are preserved; the merged canonical SHA-256 is a4abf8ca375d058a23b3ae1d91698f95c77e59f0ebd98f623da26461e6b3e08b. Standalone generator, 78 relevant tests, 29 documentation tests and diff checks passed. Fresh CI is running before the normal protected-branch merge. |
Summary
Isolate the supplementary installed-version probe from primary source-streamed SSH discovery. Preserve sessions, discovery and host/SSH identity metadata even when the probe fails. Add bounded
remoteVersionProbemetadata and a fixed human notice only on probe failure; normal installed/uninstalled output remains unchanged.Closes #265
Type
Validation
--checkandgit diff --check: passed.Notes
Primary discovery failures and per-host partial-failure exit behavior stay intact. Fixtures use the real version probe with mocked subprocess outcomes; no live SSH/native messages, service change, installation or release was performed. CI and automated source/security review remain required. The lockfile audit repair is separately tracked by #266 / PR #269.