Repository navigation
fix(control): keep mutation failures consistent and fail closed - #213
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #200. Highest-priority v1.0.2 audit finding: rejected proofs poisoned readiness, while a failed COMMIT could leave rolled-back public state advertised as healthy.
Type
Checklist
python3 cc_peer.py listworks locallypython3 cc_peer.py list --host <a real host>works over SSH--dry-runresolves a target without posting anythingThe unchecked native/SSH checks are not relevant to this Control-only change; no production services or real agent sessions were touched.
Verified against
macOS arm64, Node 22.14.0, Python 3.14.7; isolated fixture state and lockfile-installed Control dependencies.
SESSION_PEER_CONTROL_INTEGRATION=1).git diff --checkpasses.Notes
No version bump, schema change, merge, release or deployment. Control is deployed separately from the Python package.
This preserves the existing publication-failure rollback contract, not an atomic SQLite+filesystem transaction. An uncommitted snapshot may briefly be visible; after a publication/COMMIT failure readiness and admission remain closed. Recovery uses the normal 60-second refresh or restart with a higher revision. Persistent I/O errors remain unhealthy and the coordinated stack/watchdog is still required. No live systemd recovery claim is made.
Tests also cover same-challenge recovery after rejection, competing rotations, idempotent receipts, post-failure valid mutations, restart after failed COMMIT, and revision non-reuse.