Skip to content

Replace iText and NEST in the Docs module - #26216

Merged
EngincanV merged 7 commits into
devfrom
maliming/docs-remove-itext-nest
Oct 1, 2026
Merged

EngincanV merged 7 commits into
devfrom
maliming/docs-remove-itext-nest

Conversation

@maliming

Copy link
Copy Markdown
Member

Render PDF files with PdfSharpHtmlToPdfRenderer (HtmlRenderer.PdfSharp) instead of the AGPL licensed iText, and use Elastic.Clients.Elasticsearch instead of the deprecated NEST client for the full-text search. The breaking changes are in the 11.0 migration guide.

- Render PDF files with HtmlRenderer.PdfSharp instead of the AGPL licensed iText
- Use Elastic.Clients.Elasticsearch instead of the deprecated NEST client
Copilot AI balanced review requested due to automatic review settings September 30, 2026 07:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@maliming maliming added the dependency-change Indicates a version change of a dependency (typically, upgrade) label Sep 30, 2026
@maliming maliming added this to the 10.8-preview milestone Sep 30, 2026
maliming and others added 3 commits September 30, 2026 16:45
- Parse the HTML with HtmlAgilityPack and convert GIF, WebP and unsupported JPEG images with SkiaSharp
- Keep same-page and wrapped links clickable, and load only HTTP(S) images
- Replace tabs in code blocks and document the Linux and font resolver limits
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.34%. Comparing base (6e6f7ed) to head (3ffaed4).
⚠️ Report is 39 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #26216      +/-   ##
==========================================
+ Coverage   50.31%   50.34%   +0.02%     
==========================================
  Files        3842     3842              
  Lines      135790   135739      -51     
  Branches    10329    10318      -11     
==========================================
+ Hits        68329    68342      +13     
+ Misses      65395    65329      -66     
- Partials     2066     2068       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Remote image loading permits SSRF, and PDF/image resources require deterministic disposal.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)

@maliming
maliming requested a review from EngincanV October 1, 2026 06:36
@EngincanV
EngincanV merged commit e84f290 into dev Oct 1, 2026
6 checks passed
@EngincanV
EngincanV deleted the maliming/docs-remove-itext-nest branch October 1, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency-change Indicates a version change of a dependency (typically, upgrade)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants