Skip to content

Handle string is private #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AyanSinhaMahapatra merged 2 commits into from
Dec 11, 2025
Merged

Handle string is private #4635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ca178b
Add test with string is_private package.json
AyanSinhaMahapatra Dec 11, 2025
e5866d3
Handle string is_private in npm package.json
AyanSinhaMahapatra Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/packagedcode/npm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,9 @@ def _parse(cls, json_data, package_only=False):

namespace, name = split_scoped_package_name(name)

is_private = json_data.get('private') or False
is_private = False
if json_data.get('private'):
is_private = True
if is_private:
urls = {}
else:
Expand Down
158 changes: 158 additions & 0 deletions tests/packagedcode/data/npm/private/react-devtools-fusebox.package-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,158 @@
[
{
"type": "npm",
"namespace": null,
"name": "react-devtools-fusebox",
"version": "0.0.0",
"qualifiers": {},
"subpath": null,
"primary_language": "JavaScript",
"description": null,
"release_date": null,
"parties": [],
"keywords": [],
"homepage_url": null,
"download_url": "https://registry.npmjs.org/react-devtools-fusebox/-/react-devtools-fusebox-0.0.0.tgz",
"size": null,
"sha1": null,
"md5": null,
"sha256": null,
"sha512": null,
"bug_tracking_url": null,
"code_view_url": null,
"vcs_url": null,
"copyright": null,
"holder": null,
"declared_license_expression": "mit",
"declared_license_expression_spdx": "MIT",
"license_detections": [
{
"license_expression": "mit",
"license_expression_spdx": "MIT",
"matches": [
{
"license_expression": "mit",
"license_expression_spdx": "MIT",
"from_file": null,
"start_line": 1,
"end_line": 1,
"matcher": "1-spdx-id",
"score": 100.0,
"matched_length": 1,
"match_coverage": 100.0,
"rule_relevance": 100,
"rule_identifier": "spdx-license-identifier-mit-5da48780aba670b0860c46d899ed42a0f243ff06",
"rule_url": null,
"matched_text": "MIT"
}
],
"identifier": "mit-a822f434-d61f-f2b1-c792-8b8cb9e7b9bf"
}
],
"other_license_expression": null,
"other_license_expression_spdx": null,
"other_license_detections": [],
"extracted_license_statement": "- MIT\n",
"notice_text": null,
"source_packages": [],
"file_references": [],
"is_private": true,
"is_virtual": false,
"extra_data": {},
"dependencies": [
{
"purl": "pkg:npm/buffer",
"extracted_requirement": "^6.0.3",
"scope": "devDependencies",
"is_runtime": false,
"is_optional": true,
"is_pinned": false,
"is_direct": true,
"resolved_package": {},
"extra_data": {}
},
{
"purl": "pkg:npm/cross-env",
"extracted_requirement": "^7.0.3",
"scope": "devDependencies",
"is_runtime": false,
"is_optional": true,
"is_pinned": false,
"is_direct": true,
"resolved_package": {},
"extra_data": {}
},
{
"purl": "pkg:npm/css-loader",
"extracted_requirement": "^6.9.1",
"scope": "devDependencies",
"is_runtime": false,
"is_optional": true,
"is_pinned": false,
"is_direct": true,
"resolved_package": {},
"extra_data": {}
},
{
"purl": "pkg:npm/mini-css-extract-plugin",
"extracted_requirement": "^2.7.7",
"scope": "devDependencies",
"is_runtime": false,
"is_optional": true,
"is_pinned": false,
"is_direct": true,
"resolved_package": {},
"extra_data": {}
},
{
"purl": "pkg:npm/process",
"extracted_requirement": "^0.11.10",
"scope": "devDependencies",
"is_runtime": false,
"is_optional": true,
"is_pinned": false,
"is_direct": true,
"resolved_package": {},
"extra_data": {}
},
{
"purl": "pkg:npm/webpack",
"extracted_requirement": "^5.82.1",
"scope": "devDependencies",
"is_runtime": false,
"is_optional": true,
"is_pinned": false,
"is_direct": true,
"resolved_package": {},
"extra_data": {}
},
{
"purl": "pkg:npm/webpack-cli",
"extracted_requirement": "^5.1.1",
"scope": "devDependencies",
"is_runtime": false,
"is_optional": true,
"is_pinned": false,
"is_direct": true,
"resolved_package": {},
"extra_data": {}
},
{
"purl": "pkg:npm/workerize-loader",
"extracted_requirement": "^2.0.2",
"scope": "devDependencies",
"is_runtime": false,
"is_optional": true,
"is_pinned": false,
"is_direct": true,
"resolved_package": {},
"extra_data": {}
}
],
"repository_homepage_url": null,
"repository_download_url": null,
"api_data_url": null,
"datasource_id": "npm_package_json",
"purl": "pkg:npm/react-devtools-fusebox@0.0.0"
}
]
23 changes: 23 additions & 0 deletions tests/packagedcode/data/npm/private/react-devtools-fusebox.package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"name": "react-devtools-fusebox",
"version": "0.0.0",
"private": "true",
"license": "MIT",
"files": ["dist"],
"scripts": {
"build:frontend:copy-types": "cp src/*.d.ts dist/",
"build:frontend:local": "cross-env NODE_ENV=development webpack --config webpack.config.frontend.js && yarn build:frontend:copy-types",
"build:frontend": "cross-env NODE_ENV=production webpack --config webpack.config.frontend.js && yarn build:frontend:copy-types",
"build": "yarn build:frontend"
},
"devDependencies": {
"buffer": "^6.0.3",
"cross-env": "^7.0.3",
"css-loader": "^6.9.1",
"mini-css-extract-plugin": "^2.7.7",
"process": "^0.11.10",
"webpack": "^5.82.1",
"webpack-cli": "^5.1.1",
"workerize-loader": "^2.0.2"
}
}
7 changes: 7 additions & 0 deletions tests/packagedcode/test_npm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,13 @@ def test_parse_package_json_with_resolutions(self):
packages = npm.NpmPackageJsonHandler.parse(test_file)
self.check_packages_data(packages, expected_loc, regen=REGEN_TEST_FIXTURES)

def test_parse_package_json_is_private(self):
test_file = self.get_test_loc('npm/private/react-devtools-fusebox.package.json')
expected_loc = self.get_test_loc(
'npm/private/react-devtools-fusebox.package-expected.json')
packages = npm.NpmPackageJsonHandler.parse(test_file)
self.check_packages_data(packages, expected_loc, regen=REGEN_TEST_FIXTURES)

def test_is_datafile_package_lock_json_v1(self):
test_file = self.get_test_loc('npm/package-lock-v1/package-lock.json')
assert npm.NpmPackageLockJsonHandler.is_datafile(test_file)
Expand Down