Refactor and fix package assembly for installed wheels#4171
Merged
AyanSinhaMahapatra merged 3 commits intodevelopfrom Mar 5, 2025
Merged
Refactor and fix package assembly for installed wheels#4171AyanSinhaMahapatra merged 3 commits intodevelopfrom
AyanSinhaMahapatra merged 3 commits intodevelopfrom
Conversation
Reference: #4167 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
added a commit
to aboutcode-org/scancode.io
that referenced
this pull request
Feb 28, 2025
Adds the changes from aboutcode-org/scancode-toolkit#4171 Reference: aboutcode-org/scancode-toolkit#4167 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
pombredanne
requested changes
Mar 3, 2025
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks. Just a few nits for your consideration, and this is good to merge,
Member
Author
|
CI for python 3.10 on ubuntu22 is failing pretty consistently with python/cpython#83085 which is not related to changes. Ready to review again |
AyanSinhaMahapatra
force-pushed
the
fix-pypi-installed-wheel-assembly
branch
from
4262dc6 to
c4f78b4
Compare
pombredanne
requested changes
Mar 4, 2025
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
After all, checking for "site-packages" dir was a mistaken suggestion!
AyanSinhaMahapatra
force-pushed
the
fix-pypi-installed-wheel-assembly
branch
2 times, most recently
from
cbc2670 to
92b7dae
Compare
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
fix-pypi-installed-wheel-assembly
branch
from
4e567d8 to
0bd356c
Compare
Reference: #4174 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
pombredanne
approved these changes
Mar 5, 2025
| click-8.0.4.dist-info/WHEEL,sha256=G16H4A3IeoQmnOrYV4ueZGKSjhipXx8zc8nu9FGlvMA,92 | ||
| click-8.0.4.dist-info/top_level.txt,sha256=J1ZQogalYS4pphY_lPECoNMfw0HzTSrZglC4Yfwo4xA,6 | ||
| click/__init__.py,sha256=bOKrvMqmR9rN07vN_ycyrdF-EcTCl-EmuAjq-Fp4yPM,3243 | ||
| click/__pycache__/__init__.cpython-36.pyc,, |
Member
There was a problem hiding this comment.
note that these are added at installation time to RECORD... removing all these means your RECORD file is closer to that of RECORD in a .whl archive and not like the one from a site-packages installed wheel but I guess this is OK since you have a pip example of an as-installed wheel below
AyanSinhaMahapatra
added a commit
to aboutcode-org/scancode.io
that referenced
this pull request
Mar 6, 2025
This fixes pypi installed wheel package assembly by adding the changes from aboutcode-org/scancode-toolkit#4171 Reference: aboutcode-org/scancode-toolkit#4167 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: #4167
Tasks
Run tests locally to check for errors.