Add push command group and move set-apns-p12 to it#125
Add push command group and move set-apns-p12 to it#125vladvelici wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThe APNS P12 certificate command is being reorganized from the apps command group to a new dedicated push command group. Command invocation changes from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
15d0945 to
cb82c96
Compare
There was a problem hiding this comment.
Pull request overview
This pull request creates a dedicated push notifications command group and migrates the APNS certificate management command from the apps group to the new push group. The change improves the CLI's organization by grouping push notification-related commands together rather than bundling them with general app management commands.
Changes:
- Created new
pushtopic withpush:set-apns-p12command replacingapps:set-apns-p12 - Updated class name from
AppsSetApnsP12CommandtoPushSetApnsP12Command - Added
push*to anonymous web CLI restricted commands - Updated all unit tests to reflect the new command structure
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/commands/push/index.ts | New topic index command for push notifications group |
| src/commands/push/set-apns-p12.ts | Renamed class and updated examples from apps to push |
| src/commands/apps/index.ts | Removed set-apns-p12 example from apps topic |
| src/base-command.ts | Added push* to anonymous web CLI restrictions |
| test/unit/commands/push/set-apns-p12.test.ts | Updated all test command references from apps to push |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This is not needed as per https://ably.atlassian.net/browse/FTF-266, so closing the PR |
https://ably.atlassian.net/browse/FTF-266
Note
Creates a dedicated push notifications command group and migrates APNS certificate management into it.
pushtopic withpush:set-apns-p12command; examples and command class names/parse references updatedapps set-apns-p12example fromappstopicpush*commands insrc/base-command.tstest/unit/commands/push/set-apns-p12.test.tsvalidating success and error pathsWritten by Cursor Bugbot for commit cb82c96. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.