Skip to content

docs: remove internal SAP system ID from petstore3-client e2e README #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ThePlenkov wants to merge 1 commit into from
Closed

docs: remove internal SAP system ID from petstore3-client e2e README #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions samples/petstore3-client/e2e/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

This directory contains the **hand-written AUnit test class** (`src/zcl_ps3_client_tests.clas.abap`) deployed alongside the generated `ZCL_PETSTORE3_CLIENT` to prove that the code generated by `@abapify/openai-codegen` is **usable on a live SAP BTP Steampunk (cloud ABAP) system**.

## Evidence gathered on live SAP BTP systems
## Evidence gathered on live SAP BTP Steampunk

The generator was exercised against two Steampunk tenants. Both flows produce the same body; the only thing that varied was the target package.
The generator was exercised against a real Steampunk tenant (`TRL`).

### Successful deploy on `TRL` (BTP Steampunk, package `ZPEPL`)
### Successful deploy on `TRL` (package `ZPEPL`)

| Step | Command | Result |
| --------------------------------- | ------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------- |
Expand All @@ -15,13 +15,9 @@ The generator was exercised against two Steampunk tenants. Both flows produce th
| Verify generated source on server | `bunx adt --sid TRL fetch /sap/bc/adt/oo/classes/zcl_petstore3_client/source/main` | OK — returns the generator's output byte-for-byte |
| Verify class metadata | `bunx adt --sid TRL fetch /sap/bc/adt/oo/classes/zcl_petstore3_client` | OK — `adtcore:masterSystem="TRL"`, `class:category="generalObjectType"` |

### Successful deploy on `BHF` (BTP Steampunk, package `$TMP`)
## Important: `--package` must be a user-writable package on BTP

Same generated artefacts, deployed to `$TMP` on `BHF` where the service account has `S_ABPLNGVS` for that package — same `2 objects activated` result.

## Important: `--package` must be a user-writable package on TRL

On TRL, the current service account does NOT have `S_ABPLNGVS` authorization for `$TMP`. Deploying there with `--package $TMP` fails with:
On BTP Steampunk, `S_ABPLNGVS` authorization is granted per package. Deploying with `--package $TMP` can fail with:

```
HTTP 403: Forbidden - You are not authorized to make changes (authorization object S_ABPLNGVS)
Expand Down
Loading