Improve empty state messages in Tracker component - #1
Merged
Conversation
Updated the conditional rendering logic for displaying messages when there are no issues or pull requests. Enhanced user feedback for empty states.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the conditional rendering logic for displaying messages when there are no issues or pull requests. Enhanced user feedback for empty states.
##Description
Refactored the empty-state rendering logic inside the GitHub Tracker data table (src/pages/Tracker/Tracker.tsx) to properly distinguish between a total lack of user records versus page-local filtering exclusions.
##Changes introduced:
Global Empty State: Replaced the plain currentFilteredData.length === 0 check with a conditional check based on totalCount === 0. This guarantees that the friendly empty-state messages ("No issues found for this user" / "No pull requests available") only show up if the user genuinely has zero total assets on GitHub.
Filter/Pagination Empty State: Introduced a secondary conditional branch (currentFilteredData.length === 0) to catch cases where data exists globally, but a strict search filter or high pagination index returns no results. It now gracefully displays: "No matches found on this page. Try resetting your filters or changing pages."
UI Enhancements: Centered the empty state text strings natively inside a spanned element using explicit textAlign: "center" styling to blend perfectly with the Material-UI grid system.
##Type of Change
[x] Bug fix
[ ] New feature
[x] Code style update / Review refactor
[ ] Breaking change
[ ] Documentation update