Skip to content

adding language tag as env var and document env vars#1

Closed
pwnyprod wants to merge 1 commit intoaPinat:mainfrom
pwnyprod:main
Closed

adding language tag as env var and document env vars#1
pwnyprod wants to merge 1 commit intoaPinat:mainfrom
pwnyprod:main

Conversation

@pwnyprod
Copy link
Copy Markdown

@pwnyprod pwnyprod commented Aug 1, 2022

No description provided.

@aPinat
Copy link
Copy Markdown
Owner

aPinat commented Aug 1, 2022

First of all, I never really wanted to add more info/instructions/documentation to this repo for many reasons.

Secondly, the pretty much all the changes you are making are either completely wrong or irrelevant:

  • Changing hl is useless as it only changes the language the esports API is responding in and absolutely does not have to do with actual location or perhaps the leagues returned. However you then fail to see whether actual geolocation might matter further below in the code.
  • Your descriptions for key and token are absolutely incorrect and you should have seen that, if you actually tried it out.

@aPinat aPinat closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants