Skip to content

fix(provider): expose reliable Kimi thinking levels - #8

Merged
aGamingGod1234 merged 2 commits into
mainfrom
fix/kimi-thinking-levels
Aug 12, 2026
Merged

aGamingGod1234 merged 2 commits into
mainfrom
fix/kimi-thinking-levels

Conversation

@aGamingGod1234

@aGamingGod1234 aGamingGod1234 commented Aug 12, 2026 •

Copy link
Copy Markdown
Owner

Older Kimi CLI releases collapse ACP thinking effort into a misleading single Thinking On value, so T3 appears to support thinking while low/high/max writes are unavailable. Kimi also had no package-aware update action in provider settings.

This requires Kimi CLI 0.29.0 or newer, where ACP advertises the real model-specific options, rejects unverified and prerelease versions below the stable minimum, and enforces that requirement at the server session-start boundary across web, mobile, and remote clients. Kimi is wired to the official @moonshot-ai/kimi-code package for version advisories and managed updates. The Kimi user docs explain the requirement.

Verification:

  • 44 focused provider, adapter, and ACP tests pass
  • authenticated real Kimi ACP CLI probe passes
  • server typecheck passes
  • targeted production lint and formatting pass

Implemented with GPT-5.6-sol via the T3 Code Codex harness.

Copilot AI lite review requested due to automatic review settings August 12, 2026 08:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@aGamingGod1234, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a6992d17-098f-4e6a-b12d-09ddb9e9983d

📥 Commits

Reviewing files that changed from the base of the PR and between 4e62fb8 and 897b131.

📒 Files selected for processing (5)
  • apps/server/src/provider/Drivers/KimiVersion.ts
  • apps/server/src/provider/Layers/KimiAdapter.test.ts
  • apps/server/src/provider/Layers/KimiAdapter.ts
  • apps/server/src/provider/Layers/KimiProvider.test.ts
  • apps/server/src/provider/Layers/KimiProvider.ts

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9dbc7815-3da1-4a21-89da-5008b9dafd0a

📥 Commits

Reviewing files that changed from the base of the PR and between cee5123 and 4e62fb8.

📒 Files selected for processing (4)
  • apps/server/src/provider/Drivers/KimiDriver.ts
  • apps/server/src/provider/Layers/KimiProvider.test.ts
  • apps/server/src/provider/Layers/KimiProvider.ts
  • docs/user/providers-kimi.md

📝 Walkthrough

Walkthrough

The Kimi provider now requires CLI version 0.29.0 or newer, reports errors for invalid versions, and skips ACP discovery when validation fails. Kimi maintenance now uses the @moonshot-ai/kimi-code package.

Changes

Kimi provider updates

Layer / File(s) Summary
CLI version validation and coverage
apps/server/src/provider/Layers/KimiProvider.ts, apps/server/src/provider/Layers/KimiProvider.test.ts, docs/user/providers-kimi.md
The provider validates Kimi CLI versions against 0.29.0. Tests cover unsupported and unverifiable versions. Documentation states the version requirement.
Package-managed maintenance configuration
apps/server/src/provider/Drivers/KimiDriver.ts
Kimi uses package-managed maintenance for @moonshot-ai/kimi-code. Homebrew and native update handlers remain unset.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant KimiProvider
  participant KimiCLI
  participant ACPDiscovery
  KimiProvider->>KimiCLI: Request CLI version
  KimiCLI-->>KimiProvider: Return version
  KimiProvider->>KimiProvider: Validate against 0.29.0
  KimiProvider->>ACPDiscovery: Continue discovery for supported versions
  KimiProvider-->>ACPDiscovery: Return error snapshot for invalid versions
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: reliable Kimi thinking levels through provider support.
Description check ✅ Passed The description explains what changed, why it changed, and how it was verified; UI evidence is not applicable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/kimi-thinking-levels

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e62fb8033

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/server/src/provider/Layers/KimiProvider.ts Outdated
Comment thread apps/server/src/provider/Layers/KimiProvider.ts Outdated
@aGamingGod1234
aGamingGod1234 merged commit 7d2615f into main Aug 12, 2026
1 check passed
@aGamingGod1234
aGamingGod1234 deleted the fix/kimi-thinking-levels branch August 12, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants