Skip to content

chore: rename optimism to op-mainnet#422

Merged
ncitron merged 3 commits into
a16z:masterfrom
MuhtasimTanmoy:rename-optimism-to-op-mainnet
Nov 20, 2024
Merged

chore: rename optimism to op-mainnet#422
ncitron merged 3 commits into
a16z:masterfrom
MuhtasimTanmoy:rename-optimism-to-op-mainnet

Conversation

@MuhtasimTanmoy

Copy link
Copy Markdown
Contributor

Closes #421

@ncitron

ncitron commented Nov 2, 2024

Copy link
Copy Markdown
Collaborator

Let's update the operationsolarstorm endpoint as well for consistency. I'll make sure to add an alias to that url.

@MuhtasimTanmoy

Copy link
Copy Markdown
Contributor Author

Let's update the operationsolarstorm endpoint as well for consistency. I'll make sure to add an alias to that url.

@ncitron Sure.

Btw, I ran cargo test-all after replacing .env with Alchemy API Key before pushing.

Output:

running 4 tests
test get_balance ... FAILED
test get_transaction_receipt ... FAILED
test call ... FAILED
test get_transaction_by_hash ... FAILED

failures:

---- get_balance stdout ----
thread 'get_balance' panicked at tests/rpc_equivalence.rs:22:59:
called `Result::unwrap()` on an `Err` value: NotPresent

---- get_transaction_receipt stdout ----
thread 'get_transaction_receipt' panicked at tests/rpc_equivalence.rs:22:59:
called `Result::unwrap()` on an `Err` value: NotPresent

---- call stdout ----
thread 'call' panicked at tests/rpc_equivalence.rs:22:59:
called `Result::unwrap()` on an `Err` value: NotPresent
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- get_transaction_by_hash stdout ----
thread 'get_transaction_by_hash' panicked at tests/rpc_equivalence.rs:22:59:
called `Result::unwrap()` on an `Err` value: NotPresent


failures:
    call
    get_balance
    get_transaction_by_hash
    get_transaction_receipt

test result: FAILED. 0 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s

Is this something I should be concerned about?

@ncitron

ncitron commented Nov 2, 2024

Copy link
Copy Markdown
Collaborator

Yeah thats fine. Those env vars get injected by our CI which is why it fails locally.

@ncitron

ncitron commented Nov 5, 2024

Copy link
Copy Markdown
Collaborator

Did you push your commit to update the URLs?

@MuhtasimTanmoy

MuhtasimTanmoy commented Nov 6, 2024

Copy link
Copy Markdown
Contributor Author

I'll make sure to add an alias to that URL.

What should be the new URLs?

@ncitron

ncitron commented Nov 6, 2024

Copy link
Copy Markdown
Collaborator

We should change all instances of optimism.operationsolarstorm.org to op-mainnet.operationsolarstorm.org

@MuhtasimTanmoy

Copy link
Copy Markdown
Contributor Author

And this?

file: opstack/src/server/net/block_handler.rs

blocks_v3_topic: IdentTopic::new(format!("/optimism/{}/2/blocks", chain_id)) 

@ncitron

ncitron commented Nov 7, 2024

Copy link
Copy Markdown
Collaborator

No this stays the same

@MuhtasimTanmoy

Copy link
Copy Markdown
Contributor Author

done

@ncitron ncitron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron

ncitron commented Nov 11, 2024

Copy link
Copy Markdown
Collaborator

Before we merge can you run cargo fmt?

@MuhtasimTanmoy

Copy link
Copy Markdown
Contributor Author

Before we merge can you run cargo fmt?

Done. What about clippy errors?

@MuhtasimTanmoy

Copy link
Copy Markdown
Contributor Author

Any dependency?

@ncitron ncitron merged commit 362e9c9 into a16z:master Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: rename optimism to op-mainnet

2 participants