refactor(types): use canonical identifiers for default models

[WebMad]

Summary

• replace raw provider-name switch cases in getProviderDefaultModelId() with the canonical providerIdentifiers registry
• preserve all existing static, regional, custom/local, and fallback default-model behavior
• add focused tests using TDD triangulation across representative provider categories

Closes #954

TDD

The new test first overrides the canonical OpenRouter identifier. Before the implementation change, the literal-based switch fails that case and returns the Anthropic fallback. Migrating the switch to providerIdentifiers makes it pass. Additional cases triangulate the behavior across static/internal, region-dependent, custom/local, and fallback providers.

Verification

• cd packages/types && npx vitest run src/__tests__/provider-default-model.test.ts src/__tests__/provider-identifiers.test.ts — 17 passed
• cd packages/types && npm test — 253 passed
• cd packages/types && npm run check-types — passed
• cd packages/types && npm run lint — passed
• repository lint pre-commit hook — passed

Note

The repository-wide pre-push type check currently reports unrelated pre-existing errors involving MiniMax M3, Moonshot router typing, LiteLLM exports, and abandonSubtaskWithId. The affected @roo-code/types package type check passes.

Summary by CodeRabbit

• Bug Fixes
  • Improved provider default-model selection to consistently match supported provider identifiers.
  • Preserved region-specific defaults (including China-dependent behavior) and maintained Anthropic fallback behavior.
  • Prevented unintended automatic defaults for custom/local selections (such as OpenAI, Ollama, and LM Studio).
• Tests
  • Added new Vitest coverage for provider matching, regional defaults, custom/local cases, and Anthropic fallback scenarios.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: df81e6c6-f4bd-4fba-b523-b4b4d59675cc

📥 Commits

Reviewing files that changed from the base of the PR and between 64a0508 and 3486cc6.

📒 Files selected for processing (1)

• packages/types/src/__tests__/provider-default-model.test.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/types/src/tests/provider-default-model.test.ts

---

📝 Walkthrough

Walkthrough

getProviderDefaultModelId now matches providers through canonical providerIdentifiers constants. Existing defaults, regional Zai behavior, custom/local empty results, and Anthropic fallback behavior are covered by focused Vitest tests.

Changes

Provider default resolution

Layer / File(s)	Summary
Canonical provider switch packages/types/src/providers/index.ts	The default-model switch uses canonical provider identifiers while preserving existing model defaults, regional Zai selection, shared empty defaults, and fallback behavior.
Default resolution tests packages/types/src/__tests__/provider-default-model.test.ts	Tests cover static defaults, related provider categories, regional defaults, custom/local selections, and Anthropic fallbacks.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

• [BUG] OpenAI Native fallback ignores the canonical default model #992 — Covers the same default-model resolver and related provider-identifier fallback behavior.
• [ENHANCEMENT] Migrate profile model resolution to canonical provider identifiers #956 — Migrates related provider-selection logic from raw literals to canonical identifiers.
• [ENHANCEMENT] Replace remaining production provider literals and verify canonical identifier coverage #960 — Tracks broader adoption of canonical provider identifiers in provider logic.

Possibly related PRs

• Zoo-Code-Org/Zoo-Code#952 — Introduces the centralized provider identifier registry consumed by this change.
• Zoo-Code-Org/Zoo-Code#945 — Adds related Kimi Code default-model behavior used by this resolver.
• Zoo-Code-Org/Zoo-Code#793 — Modifies additional default-model branches in the same resolver.

Suggested labels: awaiting-review

Suggested reviewers: navedmerchant

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title concisely describes the main change: switching default-model selection to canonical identifiers.
Description check	✅ Passed	It covers the issue, implementation summary, and verification, though it doesn’t follow the template headings exactly.
Linked Issues check	✅ Passed	The code and tests match #954: canonical identifiers are used, defaults and fallbacks are preserved, and representative coverage was added.
Out of Scope Changes check	✅ Passed	The changes stay within default-model selection and tests in the types package, with no unrelated scope apparent.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

packages/types/src/__tests__/provider-default-model.test.ts (1)

33-35: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Cover the international Zai branch.

The test only exercises { isChina: true }; add an assertion for { isChina: false } or omitted options against internationalZAiDefaultModelId so regressions in the other branch are detected.

Proposed test addition

 	import {
 		anthropicDefaultModelId,
 		getProviderDefaultModelId,
+		internationalZAiDefaultModelId,
 		mainlandZAiDefaultModelId,
 		openRouterDefaultModelId,
 		vscodeLlmDefaultModelId,
 	} from "../providers/index.js"

 	it("preserves region-dependent defaults", () => {
 		expect(getProviderDefaultModelId(providerIdentifiers.zai, { isChina: true })).toBe(mainlandZAiDefaultModelId)
+		expect(getProviderDefaultModelId(providerIdentifiers.zai)).toBe(internationalZAiDefaultModelId)
 	})

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/types/src/__tests__/provider-default-model.test.ts` around lines 33
- 35, Extend the “preserves region-dependent defaults” test for
providerIdentifiers.zai with an assertion using { isChina: false } or omitted
options, and verify it returns internationalZAiDefaultModelId while retaining
the existing mainland assertion.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@packages/types/src/__tests__/provider-default-model.test.ts`:
- Around line 33-35: Extend the “preserves region-dependent defaults” test for
providerIdentifiers.zai with an assertion using { isChina: false } or omitted
options, and verify it returns internationalZAiDefaultModelId while retaining
the existing mainland assertion.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4bd59281-3da6-4484-abbb-6352934a72e6

📥 Commits

Reviewing files that changed from the base of the PR and between 7af1a8a and 87350ed.

📒 Files selected for processing (2)

• packages/types/src/__tests__/provider-default-model.test.ts
• packages/types/src/providers/index.ts

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[edelauna]

Thanks - noticed a small quality of life change we can make while updating this file.

[edelauna]

Thanks!