[Fix] API requests hang indefinitely on VS Code 1.122.0+#383
Merged
Conversation
roomote
Bot
added
the
roomote:auto-resolve-conflicts
Contributor
Author
|
No actionable issues found. See task
|
![roomote[bot]](https://avatars.githubusercontent.com/in/2924042?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
edelauna
marked this pull request as ready for review
May 28, 2026 12:09
edelauna
requested review from
JamesRobert20,
edelauna,
hannesrudolph,
navedmerchant and
taltas
as code owners
May 28, 2026 12:09
Contributor
Author
|
Fixed in ea7f921: restored the README |
edelauna
reviewed
May 28, 2026
edelauna
left a comment
edelauna
left a comment
Contributor
There was a problem hiding this comment.
Looks good, reviewed - not approving since don’t want to merge into main
edelauna
approved these changes
May 29, 2026
edelauna
enabled auto-merge
May 29, 2026 12:46
zephg
pushed a commit
to zephg/Zoo-Code
that referenced
this pull request
Jun 24, 2026
Brings in: - chore: prepare v3.56.0 release (Zoo-Code-Org#398) - fix: API requests hang indefinitely on VS Code 1.122.0+ (Zoo-Code-Org#383) - feat: add Claude Opus 4.8 support across Anthropic, Bedrock, and Vertex (Zoo-Code-Org#386) - Show Zoo Code in outbound provider activity logs (Zoo-Code-Org#219) Conflict resolutions and adjustments below. Anthropic Opus 4.8 (packages/types/src/providers/anthropic.ts) -------------------------------------------------------------- Kept our effort-array shape from 64fc5fc (supportsReasoningEffort: [low, medium, high, xhigh, max], default "high", requiredReasoningEffort: true). Discarded upstream's binary supportsReasoningBudget + supportsReasoningBinary shape -- the local fork uses effort-based reasoning across all Anthropic Opus 4.x models (foundation: fd93c5b). Vertex Opus 4.8 (packages/types/src/providers/vertex.ts) -------------------------------------------------------- Upstream's verbatim Vertex 4.8 entry would emit a 400 in our codebase: unlike Bedrock, Vertex has no provider-side adaptive-thinking guard, so the registry shape alone decides the request payload. With supportsReasoningBudget: true, our getAnthropicReasoning() would emit { thinking: { type: "enabled", budget_tokens } } -- which Opus 4.8 rejects. Converted Vertex 4.8 to the same effort-array shape as our Anthropic 4.8 so the helper hits the adaptive/effort branch and emits { thinking: { type: "adaptive" }, output_config: { effort: "high" } }. The pre-existing Vertex Opus 4.7 entry still uses the legacy budget shape (also broken on the API). That's a known follow-up from fd93c5b and intentionally out of scope for this merge. Vertex provider (src/api/providers/anthropic-vertex.ts) ------------------------------------------------------- Dropped upstream's explicit getAnthropicProviderReasoning() call in getModel() and the associated import. Our getModelParams({format: "anthropic"}) already returns params.reasoning via the unified getAnthropicReasoning helper (post-fd93c5bde), so the explicit call would duplicate the wiring and lose user-chosen efforts (upstream's call site omits reasoningEffort). Bedrock (src/api/providers/bedrock.ts, packages/types/src/providers/bedrock.ts) ------------------------------------------------------------------------------ Took upstream verbatim. The Bedrock provider has its own isAdaptiveThinkingModel guard that overrides the request payload regardless of registry shape, so the budget-shape registry entries are fine here. Tests (src/api/providers/__tests__/anthropic.spec.ts) ----------------------------------------------------- Rewrote four upstream-added Opus 4.8 tests that asserted the budget/binary shape to mirror our existing 4.7 effort-shape tests: - "should use adaptive thinking ..." -> assert output_config.effort: "high" - "should omit thinking when reasoning disabled" -> replaced with "should always emit adaptive thinking (reasoning is required)" - "should preserve custom maxTokens" -> replaced with "should honor user-chosen effort" (matching our 4.7 pattern) - "should handle Claude Opus 4.8 model correctly" -> assert supportsReasoningEffort array, default "high", requiredReasoningEffort Verification ------------ - pnpm -w check-types: 11/11 packages clean - pnpm -w test: 22 failures, all pre-existing in reasoning.spec.ts and model-params.spec.ts (matches MEMORY baseline from fd93c5b fixture drift). Zero new failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #381
Closes: #382
Description
This branch cuts
v3.55.1fromv3.55.0and ships the already-merged ripgrep fix from PR #248 so Zoo Code no longer hangs on VS Code 1.122.0+ after the@vscode/ripgrep-universalrename.It also updates the Marketplace-facing release notes for the hotfix across the localized
README.mdfiles, fixes the malformed</details>closing tag in the README language sections, and removes the unused release-image step from.roo/commands/release.mdso future release prep matches the current process.Test Procedure
mise exec -- pnpm --dir src exec vitest run services/ripgrep/__tests__/index.spec.tsrelease/v3.55.1and let the repo pre-push typecheck suite passapps/web-roo-codeis no longer present in this repository, so the task wrapper's web-app check is stale and was not runnable herePre-Submission Checklist
Screenshots / Videos
Not applicable for this extension runtime hotfix and Marketplace README/i18n follow-up.
Documentation Updates
Updated the Marketplace-facing
README.md, refreshed the localizedlocales/*/README.mdrelease notes forv3.55.1, and removed the unused release-image step from.roo/commands/release.md.Additional Notes
The branch contains the existing ripgrep fix commit from PR #248 plus the generated
v3.55.1version and changelog updates.Get in Touch
Opened via Roomote on behalf of Elliott de Launay.