fix: allow public schema in model config and add warning in connection form#7
Merged
Merged
Conversation
abhizipstack
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
public/PUBLICschema exclusion from PostgreSQL and Snowflakelist_all_schemas()so it appears in the model configuration schema dropdownpublicWhy
publicschema was hardcoded as excluded in the backend SQL query, so users could never select it in model configuration — even though it's a valid schema some users legitimately usepublicas the default schema without any guidancepublic, but model config hides itHow
PostgreSQL:
backend/visitran/adapters/postgres/connection.py— Removed'public'from the NOT IN clause inlist_all_schemas()backend/visitran/adapters/postgres/schema.json— Updated schema field description with recommendationSnowflake:
backend/visitran/adapters/snowflake/connection.py— Removed'PUBLIC'from the NOT IN clause inlist_all_schemas()backend/visitran/adapters/snowflake/schema.json— Updated schema field description with recommendationOther adapters (DuckDB, Trino, Databricks, BigQuery) were checked — none filter
public, no changes needed.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
publicschema see no difference. Users who do usepublicwill now see it in the model config dropdown (previously hidden). The warning in the connection form is informational only — it does not block input.Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
publicschema hidden in model configDependencies Versions
Notes on Testing
publicas the schema — verify no errorpublicnow appears in the schema dropdownScreenshots
N/A — backend changes only.
Checklist
publicschema exclusion removedPUBLICschema exclusion removed