Skip to content

Basic workflow and adapter exception messages#4

Merged
nehabagdia merged 5 commits into
mainfrom
fix/exception-handling-workflows
Feb 29, 2024
Merged

Basic workflow and adapter exception messages#4
nehabagdia merged 5 commits into
mainfrom
fix/exception-handling-workflows

Conversation

@athul-rs
Copy link
Copy Markdown
Contributor

@athul-rs athul-rs commented Feb 26, 2024

What

... Improving exception handling in workflow and adapters.

  • Improvements added on frontend side for better message handling.
  • Fixed pre-commit hook errors.

Why

... Earlier provided error messages provided earlier offered limited value to end users.

How

... Adding newer exception handle cases added where ever necessary.

Relevant Docs

Related Issues or PRs

Dependencies Versions / Env Variables

Notes on Testing

...

Screenshots

exception_workflow

adapter-error

Checklist

I have read and understood the Contribution Guidelines.

@athul-rs athul-rs requested a review from jaseemjaskp February 26, 2024 16:43
Copy link
Copy Markdown
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception handling for adapters doesn't seem robust - I think it should be handled properly along with the unstract-adapters package. The parsing of the error message could go within that particular adapter itself and our custom exception class can hold both the original error message (for logging) and the user friendly error message (for API response)

Comment thread backend/adapter_processor/views.py Outdated
Comment thread backend/adapter_processor/views.py
Comment thread backend/adapter_processor/views.py Outdated
Comment thread backend/workflow_manager/workflow/views.py
@athul-rs
Copy link
Copy Markdown
Contributor Author

The exception handling for adapters doesn't seem robust - I think it should be handled properly along with the unstract-adapters package. The parsing of the error message could go within that particular adapter itself and our custom exception class can hold both the original error message (for logging) and the user friendly error message (for API response)

This issue here is the current message from the adapters is not in any python standard formats. I tried capturing the error messages alone from there which isn't working in any way. One reason to check for this specific error is due to the fact that currently none of the error messages are handled specifically. @chandrasekharan-zipstack

Copy link
Copy Markdown
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments in this PR can be handled as a tech debt, approving these changes as an initial improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants