Basic workflow and adapter exception messages#4
Conversation
chandrasekharan-zipstack
left a comment
There was a problem hiding this comment.
The exception handling for adapters doesn't seem robust - I think it should be handled properly along with the unstract-adapters package. The parsing of the error message could go within that particular adapter itself and our custom exception class can hold both the original error message (for logging) and the user friendly error message (for API response)
This issue here is the current message from the adapters is not in any python standard formats. I tried capturing the error messages alone from there which isn't working in any way. One reason to check for this specific error is due to the fact that currently none of the error messages are handled specifically. @chandrasekharan-zipstack |
chandrasekharan-zipstack
left a comment
There was a problem hiding this comment.
The comments in this PR can be handled as a tech debt, approving these changes as an initial improvement
Basic workflow and adapter exception messages
What
... Improving exception handling in workflow and adapters.
Why
... Earlier provided error messages provided earlier offered limited value to end users.
How
... Adding newer exception handle cases added where ever necessary.
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
...
Screenshots
Checklist
I have read and understood the Contribution Guidelines.