Open
Conversation
Not yet integrated in heating management, not yet tested.
Also adjusted COP curve of ACs based on 'expert judgement'.
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest adds the J_EAConversionAirConditioner asset, and adds AC-control functionalities to all J_HeatingManagement implementations that work with J_EABuilding. The AC-control functionality is identical for all of them; based on a PI-controller.
Should be merged together with:
Zenmo/zero_results_UI#105
Zenmo/zero_Interface-Loader#255
Things that might still be improved/revised:
-COP curve of the AC is hand-tuned to this shape:
This is based on a conservative translation of some estimates I found online, but not thoroughly based in 'science' or datasheets. The deltaT here is the difference between indoor and outdoor temp, where a positive delta T means a higher outdoor temperature. When the indoor temp is higher, the COP is capped to the delta T = 0 value, so COP never goes above 5. In the most extreme cases, the outdoor temperature may reach 20 degrees higher than inside, but this is extremely rare in the Netherlands.
-The PI controller currently just uses the same P and I gains as the heating system, so control performance was not optimized specifically for the AC system.